Don't log error if info for deleted marker is not found #3474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its possible that a marker is deleted, while its info is being retrieved. This will produce a logged error such as: "Marker id 6922 not found.", while the caller continues working without the info. In this case, the logged error is not necessary - the marker is gone, not being able to retrieve its info is expected behavior. This change adjusts MarkerUtilities to not log an error for a not found Marker, if the marker is not existing at the time of catching the respective exception. Fixes: eclipse-platform#2219
|
@trancexpress 👍 from me for getting rid of usless errors, removing a marker that is removed should simply be silent. |
Test Results 3 018 files ±0 3 018 suites ±0 2h 25m 27s ⏱️ + 2m 44s For more details on these failures, see this check. Results for commit 5fec6b9. ± Comparison against base commit 68371cb. |
iloveeclipse
approved these changes
Oct 30, 2025
|
Jenkims build error is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its possible that a marker is deleted, while its info is being retrieved. This will produce a logged error such as: "Marker id 6922 not found.", while the caller continues working without the info.
In this case, the logged error is not necessary - the marker is gone, not being able to retrieve its info is expected behavior.
This change adjusts MarkerUtilities to not log an error for a not found Marker, if the marker is not existing at the time of catching the respective exception.
Fixes: #2219